Clean up HTTP version processing#7766
Merged
shinrich merged 4 commits intoapache:masterfrom May 3, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extended version of PR #7706.
@zwoop started reviewing PR #7706 and reasonably asked, why do we have two different structures/enums tracking HTTP versions. This PR gets rid of the HostDBApplicationInfo::HTTPVersion that was used in HostDBInfo. It replaces it with HTTPVersion which is used everywhere else.
Also adjust HTTPVersion to be smaller (2 uint8_t's) and stored as major and minor versions since that is how most cases were using the data. Added some constants for our current HTTP versions to get rid of inline constructors.
Because of the elimination of the HostDBApplicationInfo::HTTPVersion, we don't have to do the conversion function that was in PR #7706. Instead we can just assign the version from one member to another.