Skip to content

Add option to mostly strictly check URL characters#8012

Merged
shinrich merged 1 commit intoapache:masterfrom
shinrich:refine-url-character-checking
Jul 12, 2021
Merged

Add option to mostly strictly check URL characters#8012
shinrich merged 1 commit intoapache:masterfrom
shinrich:refine-url-character-checking

Conversation

@shinrich
Copy link
Copy Markdown
Member

@shinrich shinrich commented Jun 29, 2021 •
edited
Loading

Augments proxy.config.http.strict_uri_parsing to take three values rather than just two. Adding a mostly strict URI checking mode that will not enforce the full RFC restrictions but will ensure that white space and unprintable characters are not allowed. This restricting will be enough to detect other problems in the request line that result in odd URI's based on how ATS parses the request line.

Updates docs, unit test, and autest. Does not change the default value of proxy.config.http.strict_uri_parsing but may want to consider making 2 the default on the next major release.

@shinrich shinrich added the HTTP label Jun 29, 2021
@shinrich shinrich added this to the 10.0.0 milestone Jun 29, 2021
@shinrich shinrich self-assigned this Jun 29, 2021
@shinrich
Copy link
Copy Markdown
Member Author

shinrich commented Jun 29, 2021

[approve ci autest]

maskit
maskit approved these changes Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but we may want to update places that pass boolean values.

@shinrich shinrich merged commit 284fe0a into apache:master Jul 12, 2021
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Sep 23, 2021
zwoop added a commit to zwoop/trafficserver that referenced this pull request Jan 27, 2022
@zwoop
Default proxy.config.http.strict_uri_parsing to "2"
298dd7b 
Following up on Susan's apache#8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.
@zwoop zwoop mentioned this pull request Jan 27, 2022
Merged
zwoop pushed a commit that referenced this pull request Feb 4, 2022
@shinrich @zwoop
Add option to mostly strictly check URL characters (#8012)
9533e29 
(cherry picked from commit 284fe0a)
zwoop added a commit that referenced this pull request Feb 4, 2022
@zwoop
Default proxy.config.http.strict_uri_parsing to "2" (#8632)
03b063a 
Following up on Susan's #8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.
zwoop added a commit that referenced this pull request Feb 4, 2022
@zwoop
Default proxy.config.http.strict_uri_parsing to "2" (#8632)
eb17594 
Following up on Susan's #8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)
@zwoop zwoop modified the milestones: 9.2.0, 9.1.2 Feb 4, 2022
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Feb 4, 2022

Cherry-picked to v9.1.x branch.

zwoop added a commit that referenced this pull request Feb 11, 2022
@zwoop
Default proxy.config.http.strict_uri_parsing to "2" (#8632)
ae908c4 
Following up on Susan's #8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)
ezelkow1 pushed a commit to ezelkow1/trafficserver that referenced this pull request Feb 24, 2022
@shinrich @ezelkow1
Add option to mostly strictly check URL characters (apache#8012)
8480ee8 
(cherry picked from commit 284fe0a)
ezelkow1 pushed a commit to ezelkow1/trafficserver that referenced this pull request Feb 24, 2022
@zwoop @ezelkow1
Default proxy.config.http.strict_uri_parsing to "2" (apache#8632)
3e0edcf 
Following up on Susan's apache#8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Feb 24, 2022
@shinrich
Add option to mostly strictly check URL characters (apache#8012)
814e64d 
(cherry picked from commit 284fe0a)
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Feb 25, 2022
@shinrich
docs: Add option to mostly strictly check URL characters (apache#8012)
f6a04a4 
(cherry picked from commit 284fe0a)

This just includes the doc changes so that they run via CI separately.
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Feb 25, 2022
@shinrich
Add option to mostly strictly check URL characters (apache#8012)
5788b9a 
(cherry picked from commit 284fe0a)
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Feb 25, 2022
@shinrich @bneradt
Add option to mostly strictly check URL characters (apache#8012)
cd90448 
(cherry picked from commit 284fe0a)
ezelkow1 pushed a commit that referenced this pull request Mar 15, 2022
@bneradt @shinrich
docs: Add option to mostly strictly check URL characters (#8012) (#8703)
8c6f2ed 
(cherry picked from commit 284fe0a)

This just includes the doc changes so that they run via CI separately.

Co-authored-by: Susan Hinrichs <shinrich@verizonmedia.com>
ezelkow1 pushed a commit that referenced this pull request Mar 15, 2022
@bneradt @shinrich
Add option to mostly strictly check URL characters (#8012) (#8701)
c4e6661 
(cherry picked from commit 284fe0a)

Co-authored-by: Susan Hinrichs <shinrich@verizonmedia.com>
@bryancall bryancall mentioned this pull request Mar 16, 2022
Merged
bryancall pushed a commit to bryancall/trafficserver that referenced this pull request Mar 16, 2022
@zwoop @bryancall
Default proxy.config.http.strict_uri_parsing to "2" (apache#8632)
bd9b43a 
Following up on Susan's apache#8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)
ezelkow1 pushed a commit that referenced this pull request Mar 16, 2022
@bryancall @zwoop
Default proxy.config.http.strict_uri_parsing to "2" (#8632) (#8732)
85c319a 
Following up on Susan's #8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)

Co-authored-by: Leif Hedstrom <zwoop@apache.org>
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Jul 26, 2022
@shinrich @masaori335
Add option to mostly strictly check URL characters (apache#8012)
5cfeae6 
(cherry picked from commit 284fe0a)

Conflicts:
	tests/gold_tests/headers/good_request_after_bad.test.py
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Jul 26, 2022
@zwoop @masaori335
Default proxy.config.http.strict_uri_parsing to "2" (apache#8632)
2bd2f68 
Following up on Susan's apache#8012, this patch makes the default parsing
option "2", which enforces no white spaces in URL components.

(cherry picked from commit 03b063a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maskit maskit maskit approved these changes

@bryancall bryancall Awaiting requested review from bryancall

@SolidWallOfCode SolidWallOfCode Awaiting requested review from SolidWallOfCode

@zwoop zwoop Awaiting requested review from zwoop

Assignees

@shinrich shinrich

Labels

HTTP

Projects

None yet

Milestone

9.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@shinrich @zwoop @maskit