Set milestone for first connect before returning in the PluginVC case.#8086
Merged
randall merged 1 commit intoapache:masterfrom Jul 19, 2021
Merged
Conversation
Contributor
elsloo
commented
Jul 19, 2021
elsloo
commented
- Relocates the server first connect milestone to set it prior to connecting the plugin VC tunnel and returning
- Appears to be the fundamental cause for closed issue stms log field can have bad values. #7196
- This should negate the need for PR detect and fix stms log field having epoch time ms for intercept plugins. #7259, however, we may want to leave it in place for defensive purposes
elsloo
force-pushed
the
txn_intercept_milestone_move_first_connect
branch
from
4b06bc9 to
27aaf31
Compare
shinrich
approved these changes
Jul 19, 2021
Member
|
If we want this for 8.x can we get a backport? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.