Skip to content

Remove unused read_vio_cont/write_vio_cont methods #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinrich merged 1 commit into from
Jul 20, 2021
Merged

Remove unused read_vio_cont/write_vio_cont methods #8092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions iocore/net/I_NetVConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,12 +389,6 @@ class NetVConnection : public VConnection, public PluginUserArgs<TS_USER_ARGS_VC
*/
VIO *do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf) override = 0;

virtual Continuation *
read_vio_cont()
{
return nullptr;
}

/**
Initiates write. Thread-safe, may be called when not handling
an event from the NetVConnection, or the NetVConnection creation
Expand Down Expand Up @@ -431,11 +425,6 @@ class NetVConnection : public VConnection, public PluginUserArgs<TS_USER_ARGS_VC
*/
VIO *do_io_write(Continuation *c, int64_t nbytes, IOBufferReader *buf, bool owner = false) override = 0;

virtual Continuation *
write_vio_cont()
{
return nullptr;
}
/**
Closes the vconnection. A state machine MUST call do_io_close()
when it has finished with a VConnection. do_io_close() indicates
Expand Down
3 changes: 0 additions & 3 deletions iocore/net/P_UnixNetVConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ class UnixNetVConnection : public NetVConnection, public NetEvent
VIO *do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf) override;
VIO *do_io_write(Continuation *c, int64_t nbytes, IOBufferReader *buf, bool owner = false) override;

Continuation *read_vio_cont() override;
Continuation *write_vio_cont() override;

bool get_data(int id, void *data) override;

Action *send_OOB(Continuation *cont, char *buf, int len) override;
Expand Down
12 changes: 0 additions & 12 deletions iocore/net/UnixNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,18 +633,6 @@ UnixNetVConnection::do_io_write(Continuation *c, int64_t nbytes, IOBufferReader
return &write.vio;
}

Continuation *
UnixNetVConnection::read_vio_cont()
{
return read.vio.cont;
}

Continuation *
UnixNetVConnection::write_vio_cont()
{
return write.vio.cont;
}

void
UnixNetVConnection::do_io_close(int alerrno /* = -1 */)
{
Expand Down