Skip to content

HostDBProcessor: ensure hostname_offset is initialized to '0' to indicate null hostname #8162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traeak merged 1 commit into from
Jul 26, 2021
Merged

HostDBProcessor: ensure hostname_offset is initialized to '0' to indicate null hostname #8162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion iocore/hostdb/HostDB.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2257,7 +2257,11 @@ struct HostDBRegressionContinuation : public Continuation {
// since this is a lookup done, data is either hostdbInfo or nullptr
if (r) {
rprintf(test, "hostdbinfo r=%x\n", r);
rprintf(test, "hostdbinfo hostname=%s\n", r->perm_hostname());
char const *hname = r->perm_hostname();
if (nullptr == hname) {
hname = "(null)";
}
rprintf(test, "hostdbinfo hostname=%s\n", hname);
rprintf(test, "hostdbinfo rr %x\n", r->rr());
// If RR, print all of the enclosed records
if (r->rr()) {
Expand Down
8 changes: 4 additions & 4 deletions iocore/hostdb/I_HostDBProcessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ struct HostDBInfo : public RefCountObj {
}
}

uint64_t key;
uint64_t key{0};

// Application specific data. NOTE: We need an integral number of
// these per block. This structure is 32 bytes. (at 200k hosts =
Expand All @@ -332,11 +332,11 @@ struct HostDBInfo : public RefCountObj {
SRVInfo srv;
} data;

unsigned int hostname_offset; // always maintain a permanent copy of the hostname for non-rev dns records.
unsigned int hostname_offset{0}; // always maintain a permanent copy of the hostname for non-rev dns records.

unsigned int ip_timestamp;
unsigned int ip_timestamp{0};

unsigned int ip_timeout_interval; // bounded between 1 and HOST_DB_MAX_TTL (0x1FFFFF, 24 days)
unsigned int ip_timeout_interval{0}; // bounded between 1 and HOST_DB_MAX_TTL (0x1FFFFF, 24 days)

unsigned int is_srv : 1;
unsigned int reverse_dns : 1;
Expand Down