Skip to content

ssl_verify_test: clang-analyzer fix to account for null sni_name #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traeak merged 1 commit into from
Oct 27, 2021
Merged

ssl_verify_test: clang-analyzer fix to account for null sni_name #8462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions tests/tools/plugins/ssl_verify_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,27 @@ CB_server_verify(TSCont cont, TSEvent event, void *edata)
int count = reinterpret_cast<intptr_t>(TSContDataGet(cont));

// Is this a good name or not?
TSEvent reenable_event = TS_EVENT_CONTINUE;
TSSslConnection sslobj = TSVConnSslConnectionGet(ssl_vc);
SSL *ssl = reinterpret_cast<SSL *>(sslobj);
const char *sni_name = SSL_get_servername(ssl, TLSEXT_NAMETYPE_host_name);
TSEvent reenable_event = TS_EVENT_CONTINUE;
TSSslConnection const sslobj = TSVConnSslConnectionGet(ssl_vc);
SSL const *const ssl = reinterpret_cast<SSL *>(sslobj);
char const *const sni_name = SSL_get_servername(ssl, TLSEXT_NAMETYPE_host_name);
if (sni_name) {
std::string sni_string(sni_name);
if (bad_names.find(sni_string) != bad_names.end()) {
reenable_event = TS_EVENT_ERROR;
}
}

TSDebug(PN, "Server verify callback %d %p - event is %s SNI=%s %s", count, ssl_vc,
event == TS_EVENT_SSL_VERIFY_SERVER ? "good" : "bad", sni_name,
reenable_event == TS_EVENT_ERROR ? "error HS" : "good HS");
TSDebug(PN, "Server verify callback %d %p - event is %s SNI=%s %s", count, ssl_vc,
event == TS_EVENT_SSL_VERIFY_SERVER ? "good" : "bad", sni_name,
reenable_event == TS_EVENT_ERROR ? "error HS" : "good HS");

int len;
const char *method2_name = TSVConnSslSniGet(ssl_vc, &len);
TSDebug(PN, "Server verify callback SNI APIs match=%s", 0 == strncmp(method2_name, sni_name, len) ? "true" : "false");
int len;
char const *const method2_name = TSVConnSslSniGet(ssl_vc, &len);
TSDebug(PN, "Server verify callback SNI APIs match=%s", 0 == strncmp(method2_name, sni_name, len) ? "true" : "false");
} else {
TSDebug(PN, "SSL_get_servername failed");
reenable_event = TS_EVENT_ERROR;
}

// All done, reactivate things
TSVConnReenableEx(ssl_vc, reenable_event);
Expand Down