Skip to content

Add proxy.config.http2.stream_error_sampling_threshold#8506

Merged
masaori335 merged 1 commit intoapache:masterfrom
masaori335:fix-h2-sampling
Nov 16, 2021
Merged

Add proxy.config.http2.stream_error_sampling_threshold#8506
masaori335 merged 1 commit intoapache:masterfrom
masaori335:fix-h2-sampling

Conversation

@masaori335
Copy link
Copy Markdown
Contributor

We faced a situation to increase the proxy.config.http2.stream_error_rate_threshold (default 0.1) and noticed that increasing the rate reduces the sampling number in the Http2ConnectionState::get_stream_error_rate().

  • e.g. Imagine an error happens on the first stream, with 0.1 we would kill the conn after another 9 successful streams but at 0.3 we would kill the connection after just another 3 streams I think ( from Leif )

I'd like to introduce a config to set the minimum threshold of the sampling number.


Co-authored-by: Leif Hedstrom zwoop@apache.org

@masaori335 masaori335 added this to the 10.0.0 milestone Nov 10, 2021
@masaori335 masaori335 self-assigned this Nov 10, 2021
@masaori335 masaori335 requested a review from zwoop as a code owner November 10, 2021 01:51
Co-authored-by: Leif Hedstrom <zwoop@apache.org>
@masaori335
Copy link
Copy Markdown
Contributor Author

[approve ci]

@bneradt
Copy link
Copy Markdown
Contributor

bneradt commented Nov 16, 2021

@bneradt will review this.

Copy link
Copy Markdown
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@masaori335 masaori335 merged commit 356e3e9 into apache:master Nov 16, 2021
zwoop added a commit that referenced this pull request Nov 17, 2021
Co-authored-by: Leif Hedstrom <zwoop@apache.org>
(cherry picked from commit 356e3e9)
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Nov 17, 2021

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Nov 17, 2021
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Mar 17, 2022
* asf/9.2.x:
  Updated ChangeLog
  Marks tls_engine test as OpenSSL-only (apache#8509)
  Add skipped log entries to troubleshooting FAQ in docs. (apache#8507)
  Remove commented out EventProcessor::eventthread - it's time (apache#8517)
  Makes proxy_serve_stale version independent (apache#8508)
  Add proxy.config.http2.stream_error_sampling_threshold (apache#8506)
  url_sig: change cleanup msg from TSError to TSDebug (apache#8523)
  Adds the set-http-cntl operator for header_rewrite (apache#8375)
  Prevent bad ssl_multicert.config load from being swapped in (apache#8515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants