Prevent calling SSL_set_session in the middle of handshake#8600
Merged
maskit merged 1 commit intoapache:masterfrom Feb 1, 2022
Merged
Prevent calling SSL_set_session in the middle of handshake#8600maskit merged 1 commit intoapache:masterfrom
maskit merged 1 commit intoapache:masterfrom
Conversation
ATS crahses if origin session cache is used with BoringSSL, because BoringSSL doesn't allow you to call SSL_set_session after starting handshake.
bryancall
approved these changes
Jan 31, 2022
zwoop
pushed a commit
that referenced
this pull request
Feb 2, 2022
ATS crahses if origin session cache is used with BoringSSL, because BoringSSL doesn't allow you to call SSL_set_session after starting handshake. (cherry picked from commit 53f5869)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog Prevent calling SSL_set_session in the middle of handshake (apache#8600) Change the function signature of safe_[get|set]sockopt (apache#8331) Revert fixes for apache#8539 (apache#8637) Update descriptions of sni.yaml.default (apache#8568)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATS crashes if origin session cache is used with BoringSSL, because BoringSSL doesn't allow you to call SSL_set_session after starting handshake.
The crash is not 100% reproducible and I was only able to reproduce it on 9.2.x, but the change should make sense on master as well.
https://www.openssl.org/docs/man1.1.1/man3/SSL_set_session.html
https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#SSL_set_session
The change is very small if you hide whitespace (indent) changes.