Skip to content

Add #pragma once for PendingAction.h#8846

Merged
bneradt merged 1 commit intoapache:masterfrom
bneradt:pragma_once_for_pending_action
May 12, 2022
Merged

Add #pragma once for PendingAction.h#8846
bneradt merged 1 commit intoapache:masterfrom
bneradt:pragma_once_for_pending_action

Conversation

@bneradt
Copy link
Copy Markdown
Contributor

@bneradt bneradt commented May 12, 2022

PendingAction.h needs a #pragma once to protect it from double
inclusion. This patch adds this. This has not caused problems yet
because it is currently only used once in HttpSM.h, but as it gets more
use this will be required.

PendingAction.h needs a `#pragma once` to protect it from double
inclusion. This patch adds this. This has not caused problems yet
because it is currently only used once in HttpSM.h, but as it gets more
use this will be required.
@bneradt bneradt added the Build work related to build configuration or environment label May 12, 2022
@bneradt bneradt added this to the 10.0.0 milestone May 12, 2022
@bneradt bneradt requested a review from SolidWallOfCode May 12, 2022 20:46
@bneradt bneradt self-assigned this May 12, 2022
Copy link
Copy Markdown
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Obviously correct

@bneradt bneradt merged commit 214b892 into apache:master May 12, 2022
@bneradt bneradt deleted the pragma_once_for_pending_action branch May 12, 2022 21:34
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented May 16, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 May 16, 2022
zwoop pushed a commit that referenced this pull request May 16, 2022
PendingAction.h needs a `#pragma once` to protect it from double
inclusion. This patch adds this. This has not caused problems yet
because it is currently only used once in HttpSM.h, but as it gets more
use this will be required.

(cherry picked from commit 214b892)
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Fix parent_select optional scheme (apache#8831)
  Add `#pragma once` for PendingAction.h (apache#8846)
  Promote class PendingAction from HttpSM.h for use in other classes. (apache#8423)
  Fixes leak in SNIAction name globbing (apache#8827)
  Handle opentelemetry-cpp v1.3.0 upgrade for otel_tracer plugin (apache#8834)
  Fix overflow conditions in prefetch plugin (apache#8660)
  Remove incorrect comment from base64 functions (apache#8835)
  Add autest to cover updates to cache with alternates (apache#8779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants