Autest: Increase the delay time after a config reload rpc all was done.#8869
Closed
brbzull0 wants to merge 1 commit intoapache:masterfrom
Closed
Autest: Increase the delay time after a config reload rpc all was done.#8869brbzull0 wants to merge 1 commit intoapache:masterfrom
brbzull0 wants to merge 1 commit intoapache:masterfrom
Conversation
This particular test remap_reload seems to be failing randomly, it could be the delay time was too short, setting it to 10 now.
Contributor
|
Thank you for working on this. Let's run the autest in here a few times (maybe 4?). If the test passes each of those times, let's merge it in. |
Contributor
Author
sound good to me! thanks. |
Contributor
|
[approve ci autest] |
3 similar comments
Contributor
|
[approve ci autest] |
Contributor
|
[approve ci autest] |
Contributor
Author
|
[approve ci autest] |
Contributor
|
Reading through your patch in this PR made me realize that rather than waiting a certain amount of time for the reload to finish, we can instead await a log message that indicates that the reload has finished. Playing around with it a bit, I came up with this patch: Any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This particular test
remap_reloadseems to be failing randomly, it could be the delay time was too short, setting it to 10s now.Let's see if this fixes #8860
If not, I'll be happy to revert this back.