Skip to content

Make FileManager ctor private. #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brbzull0 merged 1 commit into from
Jun 9, 2022
Merged

Make FileManager ctor private. #8888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions mgmt2/config/FileManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ class FileManager
return isRequired;
}

// FileManager *configFiles = nullptr; // Manager to notify on an update.

// noncopyable
ConfigManager(const ConfigManager &) = delete;
ConfigManager &operator=(const ConfigManager &) = delete;
Expand All @@ -126,8 +124,10 @@ class FileManager

using CallbackType = std::function<ts::Errata(std::string const &, std::string const &)>;

FileManager();
~FileManager();
FileManager(const FileManager &obj) = delete;
FileManager &operator=(FileManager const &) = delete;

void addFile(const char *fileName, const char *configName, bool root_access_needed, bool isRequired,
ConfigManager *parentConfig = nullptr);

Expand Down Expand Up @@ -156,6 +156,8 @@ class FileManager
}

private:
FileManager();

ink_mutex accessLock; // Protects bindings hashtable
ConfigUpdateCbTable *_pluginCallbackList;

Expand Down