Cleanup: Simplify dependency around SSLNetVC and SNIConfig#8995
Merged
maskit merged 5 commits intoapache:masterfrom Aug 4, 2022
Merged
Cleanup: Simplify dependency around SSLNetVC and SNIConfig#8995maskit merged 5 commits intoapache:masterfrom
maskit merged 5 commits intoapache:masterfrom
Conversation
bneradt
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLNetVConnection.ccdoes not includeP_SSLNetVConnection.hdirectly somehow. Below is how it is included:SSLNetVConnection.cc -> P_SSLSNI.h -> P_SNIActionPerformer.h -> P_SSLNextProtocolAccept.h -> P_SSLNetVConnection.hThis is bad because files that include the other header files implicitly include
P_SSLNetVConnnection.hunnecessarily. This is why many things are rebuilt when you touchP_SSLNetVConnection.hor other header files that are included by it.Main changes on this PR are:
P_SSLNetVConnectioninSSLNetVConnection.ccActionItemintoSNIActionPerformer.has a public interfaceP_SSLSNI.htoSSLSNIConfig.h(now the name matches with the source file that contains the implementation)Changes around
I_Net.h,NetVCOptionsare for link issues due toinline.NetVCOptionsis declared inI_NetVConnection.hand some of the member functions were inP_UnixNetVConnection.has inline functions. I moved the inline functions intoI_NetVConnection.h.