TS-4744: ParentConsistentHash::selectParent may select the unavailable parent#900
Closed
keith2008 wants to merge 1 commit intoapache:masterfrom
Closed
TS-4744: ParentConsistentHash::selectParent may select the unavailable parent#900keith2008 wants to merge 1 commit intoapache:masterfrom
keith2008 wants to merge 1 commit intoapache:masterfrom
Conversation
| if (prtmp) { | ||
| pRec = (parents[last_lookup] + prtmp->idx); | ||
| } | ||
| else |
Contributor
There was a problem hiding this comment.
Please use the { } consistently. E.g.
} else {
I also don't think this would pass clang-format, so please run "make clang-format" after fixing.
Contributor
|
Traded emails with keith2008 and he asked me to resolvle the merge conflict. I'm going to close ths PR and open another one with his code changes. I'm +1 on the changes. |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 6, 2024
This calculates nbytes explicitly in send_request for HTTP/2 headers and any possibly sent body (if these are HTTP/2 trailers). This is cherry-picked from a couple unmerged commits from this PR: apache#9987 Conflicts: proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParentConsistentHash::selectParent may select the unavailable parent