Au test spawning a blocking thread in a transaction hook continuation.

[ywkaras]

Getting a result from it, without blocking event thread.

[ywkaras]

These changes are unrelated cleanup, from moving lib/cppapi to include/tscpp/api and src/tscpp/api .

[maskit]

API review on dev@ ?

[ywkaras]

API review on dev@ ?

There is not change to the TS API.

[ywkaras]

This included some unrelated cleanup of kruft leftover from lib/cppapi moving to include|src/tscpp/api .

[maskit]

API review on dev@ ?

There is not change to the TS API.

plugins/xdebug/Cleanup.h → include/tscpp/api/Cleanup.h

You are introducing a new cpp api. See discussion on #6197.

[ywkaras]

API review on dev@ ?

There is not change to the TS API.

plugins/xdebug/Cleanup.h → include/tscpp/api/Cleanup.h

You are introducing a new cpp api. See discussion on #6197.

OK done.

[maskit]

@ywkaras I meant you should send API change proposal on dev@ and I thought you did it, but I couldn't find the mail. What was done? You mean you saw the discussion?

[ywkaras]

I tried to, maybe my e-mail is blocked.

…

On Mon, Aug 29, 2022 at 7:00 PM Masakazu Kitajo ***@***.***> wrote: @ywkaras <https://urldefense.com/v3/__https://github.com/ywkaras__;!!Op6eflyXZCqGR5I!ExX3oU_U14g-aoDfEBmnfY-hoQMrnJeCPSAM9pMXA2rDTZ4ksDIgTw_W5PXIp5aBdchBh-U5RPnJEGYjw9jxl6NyUpQ$> I meant you should send API change proposal on dev@ and I thought you did it, but I couldn't find the mail. What was done? You mean you saw the discussion? — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/apache/trafficserver/pull/9044*issuecomment-1230988069__;Iw!!Op6eflyXZCqGR5I!ExX3oU_U14g-aoDfEBmnfY-hoQMrnJeCPSAM9pMXA2rDTZ4ksDIgTw_W5PXIp5aBdchBh-U5RPnJEGYjw9jx6hEibds$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AG6ILQYOM6THCW67YLEWR4TV3VFIVANCNFSM563MKV7Q__;!!Op6eflyXZCqGR5I!ExX3oU_U14g-aoDfEBmnfY-hoQMrnJeCPSAM9pMXA2rDTZ4ksDIgTw_W5PXIp5aBdchBh-U5RPnJEGYjw9jxFL40UpM$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ywkaras]

MIME-Version: 1.0
Date: Mon, 22 Aug 2022 10:25:18 -0500
Reply-To: wkaras@oath.com
Message-ID: <CANMHUGSnbxdT5z+mPG7ZfTDoAG_bW3p77dMYHwb2jhoT_-7pSg@mail.gmail.com>
Subject: Proposed change to CPP API
From: Walt Karas <wkaras@yahooinc.com>
To: dev <dev@trafficserver.apache.org>
Content-Type: multipart/alternative; boundary="0000000000002acc7f05e6d60ebf"

--0000000000002acc7f05e6d60ebf
Content-Type: text/plain; charset="UTF-8"

I propose moving Cleanup.h from plugins/xdebug to include/ts/api as a part
of https://github.com/apache/trafficserver/pull/9044 .

--0000000000002acc7f05e6d60ebf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I propose moving Cleanup.h from plugins/xdebug to include/=
ts/api as a part of=C2=A0<a href=3D"https://github.com/apache/trafficserver=
/pull/9044">https://github.com/apache/trafficserver/pull/9044</a> .</div>

--0000000000002acc7f05e6d60ebf--

[maskit]

Thanks for proposing the API change on the list. The change should be made separately even if it's accepted.

[ywkaras]

Thanks for proposing the API change on the list. The change should be made separately even if it's accepted.

How would I do that? I an using definitions in cleanup.h in the test's plugin.

[ywkaras]

OK @maskit the change you requested has been made.

Requested change was made

[maskit]

I'll leave actual code review to @rob05c,

[ywkaras]

@rob05c should I find someone else to review this?

[ywkaras]

@rob05c will you have time to review this? Should we get someone else?