Change the path for keylog_file on http2_flow_control autest#9136
Change the path for keylog_file on http2_flow_control autest#9136maskit wants to merge 3 commits intoapache:masterfrom
Conversation
| 'proxy.config.ssl.client.verify.server.policy': 'PERMISSIVE', | ||
| 'proxy.config.dns.nameservers': '127.0.0.1:{0}'.format(self._dns.Variables.Port), | ||
| 'proxy.config.ssl.keylog_file': os.path.join(Test.RunDirectory, 'tls_session_keys.txt'), | ||
| 'proxy.config.ssl.keylog_file': '/tmp/tls_session_keys.txt', |
There was a problem hiding this comment.
A downside to this is that it won't be in the sandbox then. CI, for instance, won't have this in the artifacts directory on failure. Can we instead put this in Traffic Server's log directory? (Like where diags.log is.)
There was a problem hiding this comment.
Log directory worked as well.
There was a problem hiding this comment.
After thinking about the problem you faced some, I think it could be helpful to just have the extension create the keylog file for all TLS traffic in a consistent way. This will avoid the situation where test writers choose random locations for the keylog file (like I've clearly done so far) and sometimes choosing a location which doesn't work in some CI environments. What do you think of this?
There was a problem hiding this comment.
Sounds good to me. The key logging is not a heavy task and the data size is small. I think we can enable it on all tests that use TLS/QUIC.
|
[approve ci autest] |
|
The issue was resolved by #9137. |
3 participants
Our test environment doesn't allow ATS to make files under
Test.RunDirectory. This PR changes the path to/tmpfor now, although I think Autest should provideTest.TempDirectory.