More HTTP/2 local and server renaming#9155
Conversation
maskit
left a comment
There was a problem hiding this comment.
I feel like local / remote is a more natural combination, but I'm not a best person to choose English words. I believe your choice.
I approve this PR for now, but we have remote_hpack_handle in Http2ConnectionState. Please rename it as well if you think renaming it makes sense.
|
Thanks for the review.
That's true. Often local and remote do go together. But I think in this case peer is better than remote for what these variables reference. The HTTP/2 RFC generally uses the term "peer" when referring to the other host: The term "remote" is used in the RFC, but generally to qualify peer (i.e., it says "remote peer" sometimes), or in reference in a few places to the name of a state. But in general, when discussing the other host, it calls it a "peer". Also, #9084 already started the trend of renaming the client to peer rather than remote. So if we did choose remote instead of peer, we would have to change those places too.
Good catch. Let's rename that too. |
This continues the work of apache#9084 with more renaming of HTTP/2 connection and stream variables and functions like so: * client -> peer * server -> local
ab49b73 to
ef63db2
Compare
|
Okay, let's stick with the terms that are used in RFC. |
This continues the work of apache#9084 with more renaming of HTTP/2 connection and stream variables and functions like so: * client -> peer * server -> local (cherry picked from commit 5cefa56) Conflicts: proxy/http2/Http2ConnectionState.cc proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h
This continues the work of #9084 with more renaming of HTTP/2 connection and stream variables and functions like so: