TSAN fix for fake_global_for_ink_queue.#9183
Merged
ywkaras merged 1 commit intoapache:masterfrom Mar 3, 2023
Merged
Conversation
Contributor
Author
|
Fixes this warning: |
Contributor
Author
|
Looks like this overlaps with #9168 . |
ywkaras
force-pushed
the
two_tsan
branch
3 times, most recently
from
9605fd3 to
0e66ca8
Compare
ywkaras
changed the title
| inline void | ||
| dummy_forced_read(void *mem) | ||
| { | ||
| static_cast<void>(*const_cast<int volatile *>(reinterpret_cast<int *>(mem))); |
Member
There was a problem hiding this comment.
Use [[maybe_unused]] instead of static_cast<void>()?
Also, you can static_cast to int * because it's a void *.
Finally, force_read might be a better name. There's no longer a dummy variable involved
Contributor
Author
There was a problem hiding this comment.
I prefer code that's less rather than more obscure. In any case, seems misleading to say something is maybe unused when it's definitely unused.
We should never miss a chance to use a static_cast apparently.
It's dummy in the sense that we are reading a memory location as some sort of fragile, ratchet, half-assed memory fence, rather than to read the value of a memory location. Instead of using the more portable code I wrote to replace this mess.
Member
There was a problem hiding this comment.
[[maybe_unused]] is the official replacement in C++17 for casting to void to avoid discarding computation due to optimization.
Contributor
Author
There was a problem hiding this comment.
cppreference.com as much as I does not seem to have gotten the memo you got about [[maybe_unused]]: https://en.cppreference.com/w/cpp/language/attributes/maybe_unused
SolidWallOfCode
approved these changes
Mar 2, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (28 commits) Human readable timestamp for traffic_ctl config status (apache#9440) traffic_ctl - Remove legacy/pretty format output options (apache#9471) TSAN fix for fake_global_for_ink_queue. (apache#9183) libswoc: replace TextView in src/tscore/HostLookup.cc (apache#9437) records.yaml: Make sure when a string field is set to NULL then this (apache#9472) QUIC: Make sure the some of the quic configs get set into the quiche impl. (apache#9477) Replace httpbin with go-httpbin (apache#9475) Ethread::process_event(): make sure event mutex is unlocked before freeing event. (apache#9433) Use deprecated OpenSSL APIs for MD5 and SHA256 if available (apache#9469) Adds a --enable-lto option (Link Time Optimization) (apache#9464) traffic_ctl: Add support to monitor metrics. (apache#9423) QUIC: Make some adjustment to the qlog configuration (apache#9461) Added more debugging output for the xdebug plugin (apache#9467) Build: remove configure check for sys/mount.h, use C++17 builtin. (apache#9463) Fix SSLSessionDup for old OpenSSL and BoringSSL (apache#9444) Run autest tls_hooks17 and tls_hooks18 on BoringSSL build (apache#9455) Stabilize autest tls_hook18 (apache#9454) Fix parameter parser in ssl_hook_test plugin (apache#9453) Use SSL_get1_peer_certificate on OpenSSL3 build (apache#9460) records.yaml - Make some changes on the convert script. (apache#9466) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.