Skip to content

Limit the serching range of static table by the first letter of header name #9298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 3 commits into from
Jan 23, 2023
Merged

Limit the serching range of static table by the first letter of header name #9298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4fed07
Limit the search range of static table by the first letter of header …
maskit Jan 10, 2023
ff0a06c
Add a comment
maskit Jan 20, 2023
80c7e60
Have a temporal variable
maskit Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion proxy/http2/HPACK.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,35 @@ using TS_HPACK_STATIC_TABLE_ENTRY = enum {
TS_HPACK_STATIC_TABLE_ENTRY_NUM
};

constexpr int HPACK_STATIC_TABLE_OFFSET[26] = {
TS_HPACK_STATIC_TABLE_ACCEPT_CHARSET,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_CACHE_CONTROL,
TS_HPACK_STATIC_TABLE_DATE,
TS_HPACK_STATIC_TABLE_ETAG,
TS_HPACK_STATIC_TABLE_FROM,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_HOST,
TS_HPACK_STATIC_TABLE_IF_MATCH,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_LAST_MODIFIED,
TS_HPACK_STATIC_TABLE_MAX_FORWARDS,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_PROXY_AUTHENTICATE,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_RANGE,
TS_HPACK_STATIC_TABLE_SERVER,
TS_HPACK_STATIC_TABLE_TRANSFER_ENCODING,
TS_HPACK_STATIC_TABLE_USER_AGENT,
TS_HPACK_STATIC_TABLE_VARY,
TS_HPACK_STATIC_TABLE_WWW_AUTHENTICATE,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
TS_HPACK_STATIC_TABLE_ENTRY_NUM,
};

constexpr HpackHeaderField STATIC_TABLE[] = {{"", ""},
{":authority", ""},
{":method", "GET"},
Expand Down Expand Up @@ -266,7 +295,20 @@ namespace HpackStaticTable
{
HpackLookupResult result;

for (unsigned int index = 1; index < TS_HPACK_STATIC_TABLE_ENTRY_NUM; ++index) {
// Limit the search range of static table
unsigned int start = 1; // First effective index for TS_HPACK_STATIC_TABLE_ENTRY is 1
unsigned int end = TS_HPACK_STATIC_TABLE_ENTRY_NUM;
if (const auto c = header.name[0]; 'a' <= c && c <= 'z') {
start = HPACK_STATIC_TABLE_OFFSET[c - 'a'];
if ('z' != c) {
// This does not always set the ideal end index but works for some cases
end = HPACK_STATIC_TABLE_OFFSET[c - 'a' + 1];
}
} else if (':' == c) {
end = HPACK_STATIC_TABLE_OFFSET[0];
}

for (unsigned int index = start; index < end; ++index) {
// Profiling showed that use of const reference here is more performant than copying string_views.
const std::string_view &name = STATIC_TABLE[index].name;
const std::string_view &value = STATIC_TABLE[index].value;
Expand Down