Fixed memory leaks with http/3#9342
Merged
bryancall merged 2 commits intoapache:masterfrom Feb 7, 2023
Merged
Conversation
maskit
reviewed
Jan 31, 2023
maskit
previously approved these changes
Jan 31, 2023
Contributor
Author
|
[approve ci] |
2 similar comments
Contributor
Author
|
[approve ci] |
Contributor
Author
|
[approve ci] |
bryancall
force-pushed
the
h3_memory_leaks2
branch
from
4b26841 to
1bd8810
Compare
Contributor
Author
|
[approve ci autest] |
Member
|
Doesn't the second commit leak application instance on tests? What was the problem? |
Member
|
Seems like changing base branch confuses GitHub. The diff shows code that is already on master. |
- Leak with not freeing packets - Leak in buffers for QPACK - Leak with the http/3 session
Removed unused variable
bryancall
force-pushed
the
h3_memory_leaks2
branch
from
1bd8810 to
387d3e8
Compare
maskit
approved these changes
Feb 7, 2023
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Let's leave the ownership issue for now. The change looks fine. Go ahead and merge when autest passes.
Member
|
[approve ci autest] |
moleksy
pushed a commit
to moleksy/trafficserver
that referenced
this pull request
Feb 8, 2023
- Leak with not freeing packets - Leak in buffers for QPACK - Leak with the http/3 session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These number are with not using the freelist (-f -F):
Before with previous memory leak fixes (#9336):
SUMMARY: AddressSanitizer: 3214562750 byte(s) leaked in 7288765 allocation(s).After:
SUMMARY: AddressSanitizer: 24670 byte(s) leaked in 429 allocation(s).