Rename build/ to m4/#9916
Conversation
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. I'll let a non-Yahoo committer give you an approval.
|
Please also update README.md to reflect the change in directory structure. |
This fixes an issue on case-insensitive filesystems where the BUILD item in .gitignore causes the build/ directory to be ignored in git. It also opens up build/ for use as an out of source build directory, which is a very common idiom for CMake users.
JosiahWI
force-pushed
the
feat/rename-build
branch
from
d69a73f to
482b6e4
Compare
|
Rebased on master. |
|
[approve ci autest] |
| ^BUILDS$ | ||
| ^autom4te\.cache$ | ||
| ^build$ | ||
| ^m4$ |
There was a problem hiding this comment.
Do we want rat to check our m4 files? I wonder if this line should just be removed? @bneradt do you have any input?
There was a problem hiding this comment.
RAT checks our CMake scripts. This seems like an analogous case for automake. Just my two cents.
There was a problem hiding this comment.
Probably good to check them. Let's do that as a separate PR though in case something goes wrong or we change our mind so it would be easy to revert.
|
[approve ci autest] |
It looks like it was accidentally added, so this removes it. I also put in a comment explaining why build/ is now in the .gitignore.
|
[approve ci] |
|
[approve ci ubuntu] |
|
[approve ci cmake] |
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
I feel like enough time has passed for someone to object to this. Approved!
6 participants
This fixes an issue on case-insensitive filesystems where the BUILD item in .gitignore causes the build/ directory to be ignored in git. It also opens up build/ for use as an out of source build directory, which is a very common idiom for CMake users.