Skip to content

Remove proxy.config.stat_api.max_stats_allowed, it's dead Jim #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Jun 28, 2023
Merged

Remove proxy.config.stat_api.max_stats_allowed, it's dead Jim #9923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions include/ts/ts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2083,8 +2083,7 @@ tsapi struct sockaddr const *TSNetVConnLocalAddrGet(TSVConn vc);

/* --------------------------------------------------------------------------
Stats and configs based on librecords raw stats (this is preferred API until we
rewrite stats). This system has a limitation of up to 1,500 stats max, controlled
via proxy.config.stat_api.max_stats_allowed (default is 512).
rewrite stats).

This is available as of Apache TS v2.2.*/
typedef enum {
Expand Down
3 changes: 1 addition & 2 deletions iocore/eventsystem/I_EThread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
#include "I_ProtectedQueue.h"
#include "tscpp/util/Histogram.h"

// TODO: This would be much nicer to have "run-time" configurable (or something),
// perhaps based on proxy.config.stat_api.max_stats_allowed or other configs. XXX
// TODO: This would be much nicer to have "run-time" configurable (or something)
#define PER_THREAD_DATA (1024 * 1024)

// This is not used by the cache anymore, it uses proxy.config.cache.mutex_retry_delay
Expand Down
4 changes: 0 additions & 4 deletions src/records/RecordsConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,10 +1498,6 @@ static const RecordElement RecordsConfig[] =
{RECT_LOCAL, "proxy.config.outgoing_ip_to_bind", RECD_STRING, nullptr, RECU_NULL, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,

//# Librecords based stats system (new as of v2.1.3)
{RECT_CONFIG, "proxy.config.stat_api.max_stats_allowed", RECD_INT, "256", RECU_RESTART_TS, RR_NULL, RECC_INT, "[256-1000]", RECA_NULL}
,

//############
//#
//# Per-thread freelist / allocator controls
Expand Down
2 changes: 0 additions & 2 deletions tests/gold_tests/records/gold/full_records.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,6 @@ ts:
skip_cache_on_bucket_contention: 0
timeout: 0
value: 2
stat_api:
max_stats_allowed: 256
stop:
shutdown_timeout: 0
system:
Expand Down
1 change: 0 additions & 1 deletion tests/gold_tests/records/legacy_config/full_records.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ CONFIG proxy.config.quic.congestion_control.loss_reduction_factor FLOAT 0.5
CONFIG proxy.config.quic.congestion_control.persistent_congestion_threshold INT 3
CONFIG proxy.config.incoming_ip_to_bind STRING nullptr
CONFIG proxy.config.outgoing_ip_to_bind STRING nullptr
CONFIG proxy.config.stat_api.max_stats_allowed INT 256
CONFIG proxy.config.allocator.thread_freelist_size INT 512
CONFIG proxy.config.allocator.thread_freelist_low_watermark INT 32
CONFIG proxy.config.allocator.hugepages INT 0
Expand Down