New API Metrics, and start of a libtsapi.so structure#9988
Merged
zwoop merged 13 commits intoapache:masterfrom Jul 28, 2023
Merged
New API Metrics, and start of a libtsapi.so structure#9988zwoop merged 13 commits intoapache:masterfrom
zwoop merged 13 commits intoapache:masterfrom
Conversation
zwoop
changed the title
zwoop
force-pushed
the
NewAPIMetrics
branch
5 times, most recently
from
c0c4323 to
e1b3f6c
Compare
Contributor
Author
|
[approve ci autest] |
zwoop
force-pushed
the
NewAPIMetrics
branch
2 times, most recently
from
8ea1fc6 to
b39c6af
Compare
Contributor
Author
|
I did some quick tests using the remap_stats.so plugin (a global plugin), there's no noticeable difference in performance even though I'm just putting pressure on 3 single metrics (each updated on every request). New Metrics: Old Metrics: The three metrics this plugin seems to create (these are all cache hits): |
bneradt
requested changes
Jul 13, 2023
zwoop
force-pushed
the
NewAPIMetrics
branch
10 times, most recently
from
4e8a39d to
f4eb828
Compare
Contributor
Author
|
@bneradt can you review again please ? |
bneradt
previously approved these changes
Jul 19, 2023
Contributor
|
[approve ci clang-analyzer] |
bneradt
previously approved these changes
Jul 22, 2023
The new API metrics are backwards compatible with previous APIs,
since the old API wraps these new APIs. New plugins / code could
chose to use the Metrics.h API directly.
Work to be finished here includes
1. Decide what goes into include/api ? Do we have one new
include file to #include all the include/api/*.h files?
2. What should be moved to src/api and include/api.
Lost in this merge is all the work from Chris McFarlen. Thanks!
Co-Author: Chris McFarlen <chris@mcfarlen.us>
bneradt
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new API metrics are backwards compatible with previous APIs, since the old API wraps these new APIs. New plugins / code could chose to use the Metrics.h API directly.
Work to be finished here includes
Decide what goes into include/api ? Do we have one new include file to #include all the include/api/*.h files?
What should be moved to src/api and include/api.
Lost in this merge is all the work from Chris McFarlen. Thanks!
Co-Author: Chris McFarlen chris@mcfarlen.us