Revert "feat: Add tvm_ffi.Function.__init__"

[junrushao]

Reverts #395

This PR breaks a downstream (wrong) usecase. Let's revert it for now and table it for a bit

[gemini-code-assist]

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a recently added feature that introduced an __init__ constructor to the tvm_ffi.Function class. The decision to revert was made because the new constructor was found to break a downstream use case. The aim is to temporarily remove this functionality to resolve immediate issues, with the intention of revisiting its implementation in the future.

Highlights

• Revert tvm_ffi.Function.__init__: The primary change is the complete removal of the __init__ constructor for tvm_ffi.Function, which was introduced in a previous PR. This includes its implementation in Cython and its type hint.
• Removal of related test case: The test_pyfunc_init function, which validated the functionality of the tvm_ffi.Function.__init__ constructor, has been removed.
• Minor header file adjustments: Small adjustments were made to comment blocks and /// \endcond directives within include/tvm/ffi/base_details.h.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts the addition of tvm_ffi.Function.__init__. The changes correctly remove the __init__ method from the Python interface (.pyi), its Cython implementation (.pxi), and the corresponding tests. The revert seems clean and complete. I've added a couple of comments on include/tvm/ffi/base_details.h regarding documentation inconsistencies that may have been reintroduced by this revert. These are minor points that could be addressed for improved code clarity and maintainability.