-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype: bug
Description
In the debug_executor's debug_get_output function, the out parameter can be set to None, but in the C++ implementation of the function, there is no check to see if the out parameter is None, which can result in the program reporting an error without a prompt. The details are as follows:
-
debug_get_outputfunction in tvm/python/tvm/contrib/debugger/debug_executor.py

-
C++ implementation in tvm/src/runtime/graph_executor/debug/graph_executor_debug.cc. This function has no return value and copies Ndarray directly to the out parameter in python.

-
When out is None, this will raise a direct error: segment fault

I would like to raise a pr to address this issue. Now there are two choices:
- check at python level that this out parameter cannot be None.
- check the number of arguments in C++ and return Ndarray directly when out is None. This operation has the same behavior as get_output function in executor.
I prefer the second choice. Thanks for reading and what do you suggest?
Metadata
Metadata
Assignees
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype: bug