[Relay] QLinearMatMul allows 1D weight_scale, weight_zero_point inputs #10047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanfz98
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
AndrewZhaoLuo
approved these changes
Jan 25, 2022
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
LGTM, just a small nit
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
@FZYUAN-1
Looks like CI bugged out (we recently moved servers I think). You can redo CI by pushing an empty commit e.g. git commit -m 'jostle' --allow-empty and git push
After CI passes I will merge
Contributor
Author
Thanks. Done. |
Contributor
|
Need to jostle again, looks like the CI folks did not enable autoscaling until now so your job timed out. |
Contributor
Author
Done. |
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
apache#10047) * fix after cr * fix after cr 2 * emptycommit * emptycommit 2nd try
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
apache#10047) * fix after cr * fix after cr 2 * emptycommit * emptycommit 2nd try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is to fix #9908. Previously I made a mistake in git (#9946), now this is a clean PR.
@AndrewZhaoLuo Thank you for your code review, very valuable advice !