[skip ci] Fix scipy intersphinx link #10181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
Scipy changed their docs recently to be pinned to each release, so we need to update the URL we pass to intersphinx accordingly. Skipping CI on this to unblock other developers but local testing with ```bash python tests/scripts/ci.py docs ``` both showed the same error as CI before this change and no error after.
junrushao
approved these changes
Feb 7, 2022
Member
|
Let's goooo!! |
1 task
CagtayFabry
pushed a commit
to BAMWelDX/weldx
that referenced
this pull request
Feb 8, 2022
* [doc] fix intersphinx link xref: scipy/scipy#15545, apache/tvm#10181 * [doc] added nitpick ignore for asdf-2.9.1
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Scipy changed their docs recently to be pinned to each release, so we need to update the URL we pass to intersphinx accordingly. Skipping CI on this to unblock other developers but local testing with ```bash python tests/scripts/ci.py docs ``` both showed the same error as CI before this change and no error after. Co-authored-by: driazati <driazati@users.noreply.github.com>
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 20, 2022
Follow-up from apache#10181, as the URL has changed again. From [this comment](scipy/scipy#14267 (comment)), the `html-scipyorg` portion wasn't intended to be part of the URL. This should resolve the HTTP 404 occurring in `Docs: GPU` step (e.g. [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-11269/13/pipeline/405#step-975-log-73)), by accessing `https://docs.scipy.org/doc/scipy-1.8.0/objects.inv` instead of `https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/objects.inv`
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 20, 2022
Follow-up from apache#10181, as the URL has changed again in scipy/scipy#16221. From [this comment](scipy/scipy#14267 (comment)), the `html-scipyorg` portion wasn't intended to be part of the URL. This should resolve the HTTP 404 occurring in `Docs: GPU` step (e.g. [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-11269/13/pipeline/405#step-975-log-73)), by accessing `https://docs.scipy.org/doc/scipy-1.8.0/objects.inv` instead of `https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/objects.inv`
masahi
pushed a commit
that referenced
this pull request
May 20, 2022
Follow-up from #10181, as the URL has changed again in scipy/scipy#16221. From [this comment](scipy/scipy#14267 (comment)), the `html-scipyorg` portion wasn't intended to be part of the URL. This should resolve the HTTP 404 occurring in `Docs: GPU` step (e.g. [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-11269/13/pipeline/405#step-975-log-73)), by accessing `https://docs.scipy.org/doc/scipy-1.8.0/objects.inv` instead of `https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/objects.inv`
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 23, 2022
…rsphinx link Follow-up from apache#10181 and apache#11399. Thank you to @rgommers for [pointing out] (apache#11399 (comment)) that the non-versioned link is stable and working. The use of the versioned link was only introduced to work around the breakage of the stable link, so this reverts to the pre-breakage behavior.
areusch
pushed a commit
that referenced
this pull request
May 23, 2022
…#11411) Follow-up from #10181 and #11399. Thank you to @rgommers for [pointing out] (#11399 (comment)) that the non-versioned link is stable and working. The use of the versioned link was only introduced to work around the breakage of the stable link, so this reverts to the pre-breakage behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scipy changed their docs recently to be pinned to each release, so we need to update the URL we pass to intersphinx accordingly. Skipping CI on this to unblock other developers but local testing with
both showed the same error as CI before this change and no error after.
cc @junrushao1994