[TVMC] End to end benchmarking by default #10226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Thanks for making this change @tmoreau89. I think changing the default behavior is likely going to cause issues for entrenched users. I just put up PR #10256 which exposes an end_to_end argument to the python and command line interface and defaults it to False. I think this is a less disruptive solution. |
Contributor
Author
|
@jwfromm great points, I'll close this PR in favor of your PR which seems less disruptive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End to end benchmarking was added to the VM and graph executor in order to faithfully represent execution time by accounting for data transfer overheads. This can be particularly significant on discrete GPUs, where PCI-E transfers are important to account for in a typical model serving deployment.
This PR proposes to modify the default measurement done by TVMC to always benchmark end to end execution time from CPU local device context.
Another option is to expose in TVMC a flag that lets the user perform end to end benchmarking. I recommend however not benchmarking without data transfer overheads as it presents an overly optimistic outlook on TVM performance.