[Bugfix] Added definition for constexpr char* PoolInfo variables. #10272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required for compatibility with C++14, and resolve a link-time error that was observed in debug builds on `g++-10`. For release builds, the external linkage was optimized out, so the link-time error was avoided.
Lunderberg
requested review from
comaniac,
jroesch,
junrushao,
tqchen and
vinx13
as code owners
Contributor
|
Good catch! Due to the error, fail to build on OSX today |
Member
|
cc @manupa-arm also #10147 |
manupak
approved these changes
Feb 16, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Contributor
|
Should we take in #10262 instead @Lunderberg ? |
Contributor
Author
Contributor
Author
|
Closing, duplicate of #10262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are required for compatibility with C++14, and resolve a link-time error that was observed in debug builds on
g++-10. For release builds, the external linkage was optimized out, so the link-time error was avoided.