Simple workaround for PyTorch symbol crash problem in meta schedule test #10342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
junrushao
approved these changes
Feb 22, 2022
Member
|
looks like we couldn't import torch directly: |
zxybazh
reviewed
Feb 22, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
LGTM but torch is not a tvm requirement so it might not work in the mainline.
Member
Author
|
ok added a workaround for This is a workaround on top of another workaround... |
zxybazh
approved these changes
Feb 22, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
LGTM as long as it could pass CI.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…est (apache#10342) * Simple workaround for PyTorch symbol crash problem in meta schedule test * workaround for CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, people might see an error like
This is a simple workaround for PyTorch vs LLVM symbol crash problem, that doesn't involve rebuild.
@junrushao1994 @zxybazh