[ci] Skip CI based on file globs #10456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
requested review from
a team,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
areusch
reviewed
Mar 3, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
one question, otherwise looks good
|
|
||
| def match_any(f: str) -> Optional[str]: | ||
| for glob in globs: | ||
| if fnmatch.fnmatch(f, glob): |
Contributor
There was a problem hiding this comment.
i think this doesn't quite match patterns like glob.glob does--specifically, ** doesn't work. i'm not sure it entirely matters here, but if we do want that flexibility, we may want to find a better way to do this
Member
Author
There was a problem hiding this comment.
ah good catch, fnmatch doesn't need ** to search recursively so I fixed the patterns
Contributor
There was a problem hiding this comment.
want to add a note to the constant above? can be follow-on
areusch
approved these changes
Mar 4, 2022
areusch
pushed a commit
that referenced
this pull request
Mar 4, 2022
This was broken by #10456 since that did not have a case for ignoring the `main` and staging branches. This adds it at the Jenkins level so the further scripts won't even be run if not necessary. This is marked `skip ci` but since the changes all happen before lint this is being tested. commit-id:1655b8da Co-authored-by: driazati <driazati@users.noreply.github.com>
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
Co-authored-by: driazati <driazati@users.noreply.github.com>
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
This was broken by apache#10456 since that did not have a case for ignoring the `main` and staging branches. This adds it at the Jenkins level so the further scripts won't even be run if not necessary. This is marked `skip ci` but since the changes all happen before lint this is being tested. commit-id:1655b8da Co-authored-by: driazati <driazati@users.noreply.github.com>
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Co-authored-by: driazati <driazati@users.noreply.github.com>
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This was broken by apache#10456 since that did not have a case for ignoring the `main` and staging branches. This adds it at the Jenkins level so the further scripts won't even be run if not necessary. This is marked `skip ci` but since the changes all happen before lint this is being tested. commit-id:1655b8da Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips CI for changes that only touch certain files, such as
.mdfiles ordocker/*scripts.cc @areusch