[Relay][TE] Use Relay parameter name to generated TE tensor name #10516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Lunderberg
requested review from
kparzysz-quic,
masahi and
tqchen
as code owners
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
from
c37278f to
6d7b337
Compare
Contributor
Author
|
Rebase onto main following #10535 |
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
from
564bf5e to
c5f19dc
Compare
Contributor
Author
|
Rebase onto main following merge conflict with #10577. |
Contributor
Author
|
Current CI failures due to checks for the name |
tkonolige
approved these changes
Mar 15, 2022
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
This is a very helpful change. Thanks @Lunderberg!
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
from
68d2c5b to
9ac6636
Compare
Contributor
|
@Lunderberg what's the status on this one? |
Contributor
Author
|
Currently there's one CI failure that I haven't had time to track down yet. The error message occurs during memory verification, that a buffer is undefined, but likely is caused by an earlier pass failing to update a buffer. |
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
from
9ac6636 to
f163bdd
Compare
Contributor
Author
|
Rebased onto main, since the failing test case was disabled in #10717. |
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
2 times, most recently
from
47e9550 to
30c4c8b
Compare
Contributor
Author
|
I let this one languish long enough that I no longer trust the CI checks to be up-to-date. Re-running CI. |
Previously, the TE placeholders representing relay function parameters were all named `"placeholder"`, which could be difficult to follow when debugging larger functions.
The tensor name "ethos-u", once passed through from relay to TE, resulted in invalid C++ codegen.
The tensor name is part of the hash used for these results, so the previous hashes are no longer valid.
Lunderberg
force-pushed
the
relay_name_to_te_placeholder
branch
from
8a70448 to
c7dc0ff
Compare
junrushao
pushed a commit
that referenced
this pull request
Sep 26, 2022
#10516 used the Relay parameter name when lowering to TE. However, this creates an issue when the parameter name is empty. This is legal in Relay, but results in errors during code generation. For example, this is the generated CUDA kernel for bias add: ``` extern "C" __global__ void __launch_bounds__(1024) fused_raf_op_tvm_add_kernel0( float* __restrict__ T_add, float* __restrict__ , /* Name is missing and it results in compile errors. */ float* __restrict__ _1) { T_add[((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] = ([((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] + _1[((((((int)blockIdx.x) * 16) + (((int)threadIdx.x) >> 6)) % 54) / 9)]); } ``` This PR adds "placeholder" back as a default to make sure no empty string will be passed when lowering to TE.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…che#10516) * [Relay][TE] Use Relay parameter name to generated TE tensor name Previously, the TE placeholders representing relay function parameters were all named `"placeholder"`, which could be difficult to follow when debugging larger functions.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
apache#10516 used the Relay parameter name when lowering to TE. However, this creates an issue when the parameter name is empty. This is legal in Relay, but results in errors during code generation. For example, this is the generated CUDA kernel for bias add: ``` extern "C" __global__ void __launch_bounds__(1024) fused_raf_op_tvm_add_kernel0( float* __restrict__ T_add, float* __restrict__ , /* Name is missing and it results in compile errors. */ float* __restrict__ _1) { T_add[((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] = ([((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] + _1[((((((int)blockIdx.x) * 16) + (((int)threadIdx.x) >> 6)) % 54) / 9)]); } ``` This PR adds "placeholder" back as a default to make sure no empty string will be passed when lowering to TE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the TE placeholders representing relay function parameters were all named
"placeholder", which could be difficult to follow when debugging larger functions.