-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Driver] Remove duplicate PreProcessModuleForBuild #10530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jroesch
merged 2 commits into
apache:main
from
Lunderberg:driver_api_remove_duplication
Mar 22, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| /*! | ||
| * \file src/driver/driver_api.h | ||
| * \brief Internal compiler driver APIs to drive the compilation. | ||
| * | ||
| * This module provides functionality that may be called internally | ||
| * within TVM, but is not part of the public-facing API. | ||
| */ | ||
| #ifndef TVM_DRIVER_INTERNAL_DRIVER_API_H_ | ||
| #define TVM_DRIVER_INTERNAL_DRIVER_API_H_ | ||
|
|
||
| #include <tvm/ir/module.h> | ||
| #include <tvm/target/target.h> | ||
|
|
||
| namespace tvm { | ||
|
|
||
| /*! | ||
| * \brief Build a device and host module for a specific target from a map | ||
| * contains target to IRModule. This function is used | ||
| * for heterogeneous build. | ||
| * \param input The map contains target to an IRModule. | ||
| * \param target_host The target for building host code. To use the default, | ||
| * pass Target(). | ||
| * \return The built module that contains code for different processors. | ||
| */ | ||
| runtime::Module TIRToRuntime(const Map<Target, IRModule>& input, const Target& target_host); | ||
|
|
||
| } // namespace tvm | ||
|
|
||
| #endif // TVM_DRIVER_INTERNAL_DRIVER_API_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would almost prefer we use this name or maybe come up with an even better one from build especially in internal APIs since it is not very clear what
buildmeans. We have to preserve for historical API compatibility for now but seems better to not keep in C++ if we can.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, since
buildis used pretty frequently elsewhere, and could be confusing to users. Since most places use "build" to refer to generating something that is executable, I thought it would be appropriate here. But I think I agree, since in most places "build" has an entire sequence of steps, and here there's only the one.I'm not a big fan of the name
PreProcessModuleForBuild, because I read "PreProcess" as implying that this is a pretty early step in the build pipeline, rather than being nearly the last step.The best name coming to mind is
CodeGenerationForLowLevelTIRorGenerateCodeForLowLevelTIR, but waiting for the caffeine to hit may result in better names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it with fresh post-weekend eyes, it looks like this function is already part of the external API, as one of the overloads for
tvm::build.As a proposal for naming conventions, I've made an internal
tvm::TIRToRuntime, with the name chosen to mimic the existing target-specific codegen hook. All internal usage callstvm::TIRToRuntimedirectly, while thetvm::buildoverload is maintained for the external API.