Skip to content

Fix TorchScript fallback build #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masahi merged 1 commit into from
Mar 11, 2022
Merged

Fix TorchScript fallback build #10556

masahi merged 1 commit into from
Mar 11, 2022

Conversation

@driazati
Copy link
Member

@driazati driazati commented Mar 9, 2022 •
edited
Loading

This was missing a header libtorch_runtime.h after #7401. The test in test_libtorch_ops.py is also currently being skipped in CI since torch isn't available but that's left for a follow up

cc @t-vi @masahi

@github-actions github-actions bot requested a review from masahi March 9, 2022 23:28
@driazati driazati marked this pull request as ready for review March 9, 2022 23:32
@github-actions github-actions bot requested a review from masahi March 9, 2022 23:33
@masahi
Copy link
Member

masahi commented Mar 10, 2022

please fix the lint issue.

@t-vi
Copy link
Contributor

t-vi commented Mar 10, 2022

Oh oh. Yes. I missed to git add the header - and to enable the tests.
Thank you for cleaning this up after me!
If I can help beyond what you already have here, let me know.

@driazati
Fix TorchScript fallback build
a3c4433 
This was missing a header `libtorch_runtime.h`. The test in `test_libtorch_ops.py` is also currently being skipped in CI since `torch` isn't available but that's left for a follow up

cc @t-vi @masahi

commit-id:f8998762
@masahi masahi merged commit 3a9e77b into apache:main Mar 11, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@driazati
Fix TorchScript fallback build (apache#10556)
4ecd327 
This was missing a header `libtorch_runtime.h`. The test in `test_libtorch_ops.py` is also currently being skipped in CI since `torch` isn't available but that's left for a follow up

cc @t-vi @masahi

commit-id:f8998762

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiics zhiics Awaiting requested review from zhiics

@trevor-m trevor-m Awaiting requested review from trevor-m

@comaniac comaniac Awaiting requested review from comaniac

@mbaret mbaret Awaiting requested review from mbaret

@manupak manupak Awaiting requested review from manupak

@vinx13 vinx13 Awaiting requested review from vinx13

@tqchen tqchen Awaiting requested review from tqchen

@liangfu liangfu Awaiting requested review from liangfu

@areusch areusch Awaiting requested review from areusch

@tmoreau89 tmoreau89 Awaiting requested review from tmoreau89

@kazum kazum Awaiting requested review from kazum

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@junrushao junrushao Awaiting requested review from junrushao

@jroesch jroesch Awaiting requested review from jroesch

@yzhliu yzhliu Awaiting requested review from yzhliu

@merrymercy merrymercy Awaiting requested review from merrymercy

@icemelon icemelon Awaiting requested review from icemelon

@masahi masahi Awaiting requested review from masahi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driazati @masahi @t-vi