Skip to content

[Arith] Fix floormod rewrite simplify rule #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
junrushao merged 1 commit into from
Mar 16, 2022
Merged

[Arith] Fix floormod rewrite simplify rule #10626

junrushao merged 1 commit into from
Mar 16, 2022

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Mar 15, 2022

@github-actions github-actions bot requested a review from junrushao March 15, 2022 21:52
@tkonolige
Copy link
Contributor

tkonolige commented Mar 15, 2022

This PR supersedes #10618.

@vinx13 can you confirm that the error is no longer present if seed = 8607320357002032383 here: https://github.com/apache/tvm/blob/main/tests/python/unittest/test_arith_solve_linear_inequality.py#L25?

@vinx13
Copy link
Member Author

vinx13 commented Mar 15, 2022

@tkonolige I can confirm it pass the test with the given seed

@driazati driazati mentioned this pull request Mar 16, 2022
Closed
@junrushao junrushao merged commit 6991396 into apache:main Mar 16, 2022
@masahi masahi mentioned this pull request Mar 16, 2022
Merged
@vinx13 vinx13 mentioned this pull request Apr 4, 2022
Closed
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@vinx13
[Arith] Fix floormod rewrite simplify rule (apache#10626)
b074a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushao junrushao junrushao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinx13 @tkonolige @junrushao