Skip to content

Conversation

@tkonolige
Copy link
Contributor

The check for if the error_no was valid was wrong.

@masahi @jwfromm

@tkonolige tkonolige force-pushed the fix_measure_result_printing branch 4 times, most recently from 3a5aa8b to 7a63f2c Compare March 21, 2022 23:18
@tkonolige
Copy link
Contributor Author

@masahi Could you review?

Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, we are unsure of what causes the non int, non enum case being hit. But still want the condition to be flipped.

@AndrewZhaoLuo
Copy link
Contributor

Looks like a scary error

Tristan Konolige added 2 commits March 23, 2022 09:16
The check for if the error_no was valid was wrong.
@tkonolige tkonolige force-pushed the fix_measure_result_printing branch from 79bf01f to 820b494 Compare March 23, 2022 16:17
@tkonolige
Copy link
Contributor Author

It's caused by #10717, rebased.

@AndrewZhaoLuo AndrewZhaoLuo merged commit 93969db into apache:main Mar 24, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
* [FIX,AUTOTVM] Fix printing of measure results

The check for if the error_no was valid was wrong.

* switch logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants