[Pass][Bugfix] StorageFlatten, buffer var definitions in LetStmt #10788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any buffers whose buffer var was defined in a Let or LetStmt would result in an error when running `StorageFlatten`, stating that the buffer var was undefined. These are used for allocations in external calls, such as those produced by `LowerVtcmAlloc`.
Lunderberg
force-pushed
the
storageflatten_allow_letstmt
branch
from
ab5e6be to
f31905c
Compare
Contributor
Author
|
Rebased onto main to restart CI, had stalled out in tvm-ci/pr-merge step. |
masahi
approved these changes
Mar 29, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…che#10788) Previously, any buffers whose buffer var was defined in a Let or LetStmt would result in an error when running `StorageFlatten`, stating that the buffer var was undefined. These are used for allocations in external calls, such as those produced by `LowerVtcmAlloc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any buffers whose buffer var was defined in a Let or LetStmt would result in an error when running
StorageFlatten, stating that the buffer var was undefined. These are used for allocations in external calls, such as those produced byLowerVtcmAlloc.