[hotfix] Fix the behavior of decompose reduction #10809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
approved these changes
Mar 29, 2022
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, I verified locally that it fixed my issue.
junrushao
approved these changes
Mar 29, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for fixing it so quickly!
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Mar 29, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the bug introduced in #10638 , where I used
const_castto change the field of a block, which may affect other modules because different modules might share the same block.I also add a test to check whether the decompose reduction would affect the hash value of other modules.
cc @masahi @Hzfengsy