-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[CI][Docker] Update scripts for Hexagon CI image with 20.04 #10841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @supersat |
bb3fa82 to
a52fb19
Compare
|
@driazati I realized the pipeline didn't trigger |
|
Make sure that the |
We’re still working on the Docker image update process (if the build ran it’d use the old image and not tell us anything useful), if you want to test the changes now you’ll have to merge this and then test out once the image in |
|
@kparzysz-quic the new image passes the tests, so that should be fine. |
|
@driazati cool, so we do it the old way |
|
AFAIK, qaic isn't used in the CI tests because they just use the simulator. However, for real devices, qaic will need to work. Installing the libncurses5 package and manually pulling down http://mirrors.kernel.org/ubuntu/pool/main/libf/libffi/libffi6_3.2.1-8_amd64.deb and installing that seems to get the SDK to behave just fine on Ubuntu 20.04. |
|
@supersat sorry I should have clarified. I have tested them on real device and it worked fine. |
|
One other thing I noticed is that the SDK's setup_sdk_env.source needs to be run at least once to copy the right version of qaic in to place. And looking at it just now, it seems that SDK 4.5.0.3 has a version for Ubuntu 20.04 in ipc/fastrpc/qaic/Ubuntu20 |
Interesting! The version that I installed a while back didn't have it. I guess it was updated in the meantime. Thanks for the information. |
Building apps/hexagon_api automatically builds the binaries for simulator and hardware. |
|
Would it possibly make sense to switch to Ubuntu 20.04 and a newer / newest version of the Hexagon SDK at the same time? I realize changing one thing at a time is ideal, but (as mentioned above) it seems like there could be some dependency coupling. |
|
Looks like there's a hardcoded dependency on the Ubuntu 18.04 version of qaic here: tvm/cmake/modules/HexagonSDK.cmake Line 101 in 69bb71c
|
Yes, I'll create a PR with the fix on Monday. |
|
|
@kparzysz-quic @cconvey we could do a single update on docker image instead of multiple steps since every docker update has a long process. I'll update this PR to only have updated scripts without changing the Docker file. |
a52fb19 to
6241392
Compare
This PR makes required adjustments to update Hexagon CI image to ubuntu 20.04. The base image is built by Ubuntu 20.04
cc @areusch @driazati