Skip to content

Conversation

@mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Mar 31, 2022

This PR makes required adjustments to update Hexagon CI image to ubuntu 20.04. The base image is built by Ubuntu 20.04

cc @areusch @driazati

@mehrdadh
Copy link
Member Author

@mehrdadh
Copy link
Member Author

cc @supersat

@mehrdadh mehrdadh changed the title [Hexagon][Docker][CI]Update Hexagon CI image to 20.04 [Hexagon][Docker]Update Hexagon CI image to 20.04 Mar 31, 2022
@github-actions github-actions bot requested a review from areusch March 31, 2022 06:56
@mehrdadh mehrdadh force-pushed the hexagon/ubuntu_20.04 branch 2 times, most recently from bb3fa82 to a52fb19 Compare March 31, 2022 07:22
@mehrdadh
Copy link
Member Author

@driazati I realized the pipeline didn't trigger BUILD: Hexagon stage. wdyt?

@kparzysz-quic
Copy link
Contributor

Make sure that the qaic compiler from the SDK works on this system. On my installation of 20.04, the qaic for Ubuntu18 is looking for an older version of some shared library, and there is no official version of qaic for 20.04 in the SDK.

@driazati
Copy link
Member

@driazati I realized the pipeline didn't trigger BUILD: Hexagon stage. wdyt?

We’re still working on the Docker image update process (if the build ran it’d use the old image and not tell us anything useful), if you want to test the changes now you’ll have to merge this and then test out once the image in tlcpackstaging is updated

@mehrdadh
Copy link
Member Author

@kparzysz-quic the new image passes the tests, so that should be fine.

@mehrdadh
Copy link
Member Author

@driazati cool, so we do it the old way

@supersat
Copy link
Contributor

AFAIK, qaic isn't used in the CI tests because they just use the simulator. However, for real devices, qaic will need to work.

Installing the libncurses5 package and manually pulling down http://mirrors.kernel.org/ubuntu/pool/main/libf/libffi/libffi6_3.2.1-8_amd64.deb and installing that seems to get the SDK to behave just fine on Ubuntu 20.04.

@mehrdadh
Copy link
Member Author

@supersat sorry I should have clarified. I have tested them on real device and it worked fine.

@supersat
Copy link
Contributor

One other thing I noticed is that the SDK's setup_sdk_env.source needs to be run at least once to copy the right version of qaic in to place.

And looking at it just now, it seems that SDK 4.5.0.3 has a version for Ubuntu 20.04 in ipc/fastrpc/qaic/Ubuntu20

@kparzysz-quic
Copy link
Contributor

And looking at it just now, it seems that SDK 4.5.0.3 has a version for Ubuntu 20.04 in ipc/fastrpc/qaic/Ubuntu20

Interesting! The version that I installed a while back didn't have it. I guess it was updated in the meantime. Thanks for the information.

@kparzysz-quic
Copy link
Contributor

AFAIK, qaic isn't used in the CI tests because they just use the simulator. However, for real devices, qaic will need to work.

Building apps/hexagon_api automatically builds the binaries for simulator and hardware.

@cconvey
Copy link
Contributor

cconvey commented Apr 1, 2022

Would it possibly make sense to switch to Ubuntu 20.04 and a newer / newest version of the Hexagon SDK at the same time?

I realize changing one thing at a time is ideal, but (as mentioned above) it seems like there could be some dependency coupling.

@supersat
Copy link
Contributor

supersat commented Apr 1, 2022

Looks like there's a hardcoded dependency on the Ubuntu 18.04 version of qaic here:

"${_hexagon_sdk_root}/ipc/fastrpc/qaic/Ubuntu18/qaic"

@kparzysz-quic
Copy link
Contributor

Looks like there's a hardcoded dependency on the Ubuntu 18.04 version of qaic here:

Yes, I'll create a PR with the fix on Monday.

@kparzysz-quic
Copy link
Contributor

Looks like there's a hardcoded dependency on the Ubuntu 18.04 version of qaic here:

Yes, I'll create a PR with the fix on Monday.

#10891

@mehrdadh
Copy link
Member Author

mehrdadh commented Apr 5, 2022

@kparzysz-quic @cconvey we could do a single update on docker image instead of multiple steps since every docker update has a long process. I'll update this PR to only have updated scripts without changing the Docker file.
In the meantime I will prepare the base image with SDK that @supersat mentioned which has official support for Ubuntu 20.04.

@mehrdadh mehrdadh force-pushed the hexagon/ubuntu_20.04 branch from a52fb19 to 6241392 Compare April 5, 2022 17:20
@mehrdadh mehrdadh changed the title [Hexagon][Docker]Update Hexagon CI image to 20.04 [CI][Docker] Update scripts for Hexagon CI image with 20.04 Apr 5, 2022
@areusch areusch merged commit c91e356 into apache:main Apr 5, 2022
@mehrdadh mehrdadh deleted the hexagon/ubuntu_20.04 branch April 5, 2022 21:12
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
mehrdadh added a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants