Skip to content

Conversation

@Lunderberg
Copy link
Contributor

Previously, the schedules in test_2d_physical_buffers.py were lowered and built into a runtime::Module, but were not executed.

@Lunderberg
Copy link
Contributor Author

Lunderberg commented Apr 5, 2022

This PR requires the reduced memory footprint made in #10903 , in draft mode until it lands.

Previously, the schedules in `test_2d_physical_buffers.py` were
lowered and built into a `runtime::Module`, but were not executed.
@Lunderberg Lunderberg force-pushed the hexagon_2d_vtcm_execution branch from ee33e76 to 3a91988 Compare April 6, 2022 16:02
@Lunderberg
Copy link
Contributor Author

Lunderberg commented Apr 6, 2022

Rebasing onto main following #10903 being merged into main.

@Lunderberg Lunderberg marked this pull request as ready for review April 6, 2022 16:03
Copy link
Contributor

@adstraw adstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small PR that represents a HUGE amount of work and a monumental feature-add to TVM. Great to see transform_layout tested so extensively. Nice work @Lunderberg!

@Lunderberg
Copy link
Contributor Author

Minor update, the test_execute function should only be executed as part of task_python_hexagon_simulator.sh, where ANDROID_SERIAL_NUMBER=simulator, and should be skipped in task_python_hexagon.sh.

@kparzysz-quic kparzysz-quic merged commit c092700 into apache:main Apr 7, 2022
@Lunderberg Lunderberg deleted the hexagon_2d_vtcm_execution branch April 8, 2022 13:07
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
* [Hexagon] Add unit tests executing 2-d VTCM usage

Previously, the schedules in `test_2d_physical_buffers.py` were
lowered and built into a `runtime::Module`, but were not executed.

* Added a missing function definition in the PR branch.

* Only run test_execute on simulator in CI
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
* [Hexagon] Add unit tests executing 2-d VTCM usage

Previously, the schedules in `test_2d_physical_buffers.py` were
lowered and built into a `runtime::Module`, but were not executed.

* Added a missing function definition in the PR branch.

* Only run test_execute on simulator in CI
Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
* [Hexagon] Add unit tests executing 2-d VTCM usage

Previously, the schedules in `test_2d_physical_buffers.py` were
lowered and built into a `runtime::Module`, but were not executed.

* Added a missing function definition in the PR branch.

* Only run test_execute on simulator in CI
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
* [Hexagon] Add unit tests executing 2-d VTCM usage

Previously, the schedules in `test_2d_physical_buffers.py` were
lowered and built into a `runtime::Module`, but were not executed.

* Added a missing function definition in the PR branch.

* Only run test_execute on simulator in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants