Generate Lower Bound Conditions for issue 1014 #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync from dmlc/tvm
update the fork branch
sync up
sync up
sync up
Member
|
there is a regression test failure, @kun-zh can you look into that? http://mode-gpu.cs.washington.edu:8080/blue/organizations/jenkins/dmlc%2Ftvm/detail/PR-1091/3/pipeline |
tqchen
requested changes
Apr 10, 2018
src/schedule/message_passing.cc
Outdated
| Expr value = ComputeExpr<Sub>(value_map.at(iv), iv->dom->min); | ||
| Expr vmin = EvalSet(value, iset_dmap).min(); | ||
| Expr vmax = EvalSet(value, iset_dmap).max(); | ||
| if (vmin.type() != value.type() || !can_prove(vmin > (iv->dom->min - 1))) { |
src/schedule/message_passing.cc
Outdated
| Expr vmin = EvalSet(value, iset_dmap).min(); | ||
| Expr vmax = EvalSet(value, iset_dmap).max(); | ||
| if (vmin.type() != value.type() || !can_prove(vmin > (iv->dom->min - 1))) { | ||
| preds.emplace_back(value > (iv->dom->min - 1)); |
Contributor
Author
|
refined and fixed regression failure |
tqchen
approved these changes
Apr 11, 2018
tqchen
requested changes
Apr 11, 2018
src/schedule/message_passing.cc
Outdated
| CHECK(iv->dom.defined()); | ||
| if (!skip_ivar_domain && !iv->dom.same_as(dom)) { | ||
| Expr value = ComputeExpr<Sub>(value_map.at(iv), iv->dom->min); | ||
| Expr vmin = EvalSet(value, iset_dmap).min(); |
Member
There was a problem hiding this comment.
Do EvalSet once, instead of multiple times
Member
There was a problem hiding this comment.
specifically, cache the result of EvalSet and then get min and max
tqchen
approved these changes
Apr 12, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
This was referenced Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Lower Bound Conditions for issue #1014