Skip to content

[Bug] narrow thread extents to 32 bits for GPU lowering #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
altanh wants to merge 4 commits into from
Closed

[Bug] narrow thread extents to 32 bits for GPU lowering #10969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
617f40d
hotfix edge case for broadcast_to const shape int64
altanh Apr 11, 2022
27db291
narrow extents to int32 on gpu
altanh Apr 12, 2022
0ad6d98
check that narrowing can be done safely
altanh Apr 12, 2022
38f2711
remove CanProveLess check
altanh Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tir/transforms/narrow_datatype.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,12 @@ class DataTypeVisitor final : public StmtExprVisitor {
IterVar iv = Downcast<IterVar>(op->node);
ICHECK_NE(iv->thread_tag.length(), 0U);
analyzer_.Bind(iv->var, Range::FromMinExtent(0, op->value));
vextent_[iv->var.as<VarNode>()] = op->value.dtype();
if (op->attr_key == attr::thread_extent) {
// Narrow extents to 32 bits on GPU.
vextent_[iv->var.as<VarNode>()] = DataType::Int(32);
} else {
vextent_[iv->var.as<VarNode>()] = op->value.dtype();
}
StmtExprVisitor::VisitStmt_(op);
} else {
StmtExprVisitor::VisitStmt_(op);
Expand Down
17 changes: 17 additions & 0 deletions tests/python/relay/test_op_level10.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,23 @@ def test_broadcast_to():
tvm.testing.assert_allclose(op_res.numpy(), ref_res, rtol=1e-5)


@tvm.testing.uses_gpu
def test_broadcast_to_const_shape_int64():
shape_like = relay.const(np.array([1, 5]), dtype="int64")
x = relay.var("x", shape=(1,), dtype="int64")
z = relay.broadcast_to(x, shape=shape_like)
z = relay.sum(z, axis=0)

f = relay.Function([x], z)

x = np.random.randint(10, size=(1,), dtype="int64")
ref_res = np.broadcast_to(x, (5,))
for target, dev in tvm.testing.enabled_targets():
for kind in ["graph", "debug"]:
op_res = relay.create_executor(kind, device=dev, target=target).evaluate(f)(x)
tvm.testing.assert_allclose(op_res.numpy(), ref_res)


@tvm.testing.uses_gpu
def test_broadcast_to_like():
shape = (4, 1, 6)
Expand Down