-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix typo in tutorial doc #10974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in tutorial doc #10974
Conversation
| # | ||
| # And you can print the results: | ||
| # ``print(results)`` | ||
| # ``print(result)`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also fix my_model in line 71? Like:
s/my_model/'my_model.onnx'/ ?
Also, since you'll need to re-trigger the CI, would you mind to:
in lines 240 and 245 add a space after second comma, i.e. s/"llvm",tuning_records/"llvm", tuning_records/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I have re-triggered the CI and fix typos mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexqdh . Thanks for the fix! The change looks good.
Since you'll need to re-trigger the CI, I just have two additional questions (please see the comments inline).
For re-triggering the CI, just git push --force your amended commit (the change is small so a force is ok here). I can't see your commit caused the CI error, hence let's just try again (re-trigger the CI). Finally, if possible, please use upper case in the first letter of the title ("Fix typo ... ").
|
@alexqdh Thank you. Merged. |
Fix typo in the commented out code in TVMC Python tutorial.
Fix typo in the commented out code in TVMC Python tutorial.
fix typo in tutorial doc