Skip to content

Conversation

@alexqdh
Copy link
Contributor

@alexqdh alexqdh commented Apr 12, 2022

fix typo in tutorial doc

#
# And you can print the results:
# ``print(results)``
# ``print(result)``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also fix my_model in line 71? Like:

s/my_model/'my_model.onnx'/ ?

Also, since you'll need to re-trigger the CI, would you mind to:

in lines 240 and 245 add a space after second comma, i.e. s/"llvm",tuning_records/"llvm", tuning_records/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have re-triggered the CI and fix typos mentioned above.

Copy link
Contributor

@gromero gromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexqdh . Thanks for the fix! The change looks good.

Since you'll need to re-trigger the CI, I just have two additional questions (please see the comments inline).

For re-triggering the CI, just git push --force your amended commit (the change is small so a force is ok here). I can't see your commit caused the CI error, hence let's just try again (re-trigger the CI). Finally, if possible, please use upper case in the first letter of the title ("Fix typo ... ").

@gromero gromero self-assigned this Apr 14, 2022
@gromero
Copy link
Contributor

gromero commented Apr 14, 2022

@alexqdh Yeah the CI error is now fixed by @areusch (#11007) So please just re-trigger. Thank you.

@alexqdh alexqdh changed the title fix typo in tutorial doc Fix typo in tutorial doc Apr 15, 2022
@gromero gromero merged commit 240fac4 into apache:main Apr 18, 2022
@gromero
Copy link
Contributor

gromero commented Apr 18, 2022

@alexqdh Thank you. Merged.

Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
Fix typo in the commented out code in TVMC Python tutorial.
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
Fix typo in the commented out code in TVMC Python tutorial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants