Revert "[OpenCL] Fix type casting error" #11035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echuraev
added a commit
to echuraev/tvm
that referenced
this pull request
Apr 18, 2022
The previous PR apache#11021 was reverted in apache#11035 due to it affected performance of generated OpenCL code. This PR fixed the same issue but doesn't lead to performance degradation. Tested on Resnet50_v2 network.
This reverts commit 8aafe5b.
echuraev
force-pushed
the
revert-11021-echuraev/fix_opencl_type_casting
branch
from
a8aa588 to
7f9d231
Compare
masahi
approved these changes
Apr 19, 2022
echuraev
added a commit
to echuraev/tvm
that referenced
this pull request
Apr 19, 2022
The previous PR apache#11021 was reverted in apache#11035 due to it affected performance of generated OpenCL code. This PR fixed the same issue but doesn't lead to performance degradation. Tested on Resnet50_v2 network.
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
This reverts commit 8aafe5b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11021
Found that this PR can affect performance of OpenCL inference. I'll try to fix this issue in another way.
@masahi Could you please revert it?