[TIR] Bind iter domain in analyzer in CreatePrimFunc #11187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
approved these changes
Apr 29, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM! BTW, does it guarantee that the PrimFunc created is simplified?
Member
Author
|
It makes best efforts. But generally arith analyzer doesn't guarantee the result is simplified |
Member
|
Do you think it might make sense to call the Simplify pass upon PrimFunc creation? |
Member
Author
|
We've already called |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* [TIR] Bind iter domain in analyzer in CreatePrimFunc * lint * fix test
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
* [TIR] Bind iter domain in analyzer in CreatePrimFunc * lint * fix test
jinhongyii
pushed a commit
to jinhongyii/tvm
that referenced
this pull request
Jun 20, 2022
* [TIR] Bind iter domain in analyzer in CreatePrimFunc * lint * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Hzfengsy @junrushao1994