fix ccache #11189
Merged
fix ccache #11189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconvey
force-pushed
the
fix-ccache
branch
5 times, most recently
from
3fc0f39 to
d305099
Compare
Contributor
Author
cconvey
commented
Apr 29, 2022
cconvey
force-pushed
the
fix-ccache
branch
3 times, most recently
from
0e3d99d to
f49e714
Compare
cconvey
commented
May 3, 2022
cconvey
commented
May 3, 2022
cconvey
commented
May 3, 2022
adstraw
reviewed
May 3, 2022
Contributor
adstraw
left a comment
adstraw
left a comment
There was a problem hiding this comment.
Overall LGTM. A few nits.
- Remove TVM's `USE_CCACHE` option in favor
of CMake's built-in `CMAKE_C_COMPILER_LAUNCHER`
and `CMAKE_CXX_COMPILER_LAUNCHER` variables.
This eliminates a significant source of
complexity, especially:
- TVM's CI scripts, which use `sccache`
instead of `ccache`, and
- calls to `ExternalProject_add` in TVM's CMake logic.
- Ensure that `CMAKE_C[XX]_COMPILER_LAUNCHER` variables
are passed through in all `ExternalProject_add` calls.
- Update user documentation.
Contributor
Author
|
@mehrdadh : Ready for merge if/when you're happy. |
areusch
approved these changes
May 17, 2022
| export TVM_LOG_DEBUG="ir/transform.cc=1;relay/ir/transform.cc=1" | ||
|
|
||
| - TVM requires LLVM for for CPU codegen. We highly recommend you to build with the LLVM support on. | ||
| - TVM requires LLVM for CPU codegen. We highly recommend you to build with the LLVM support on. |
Contributor
There was a problem hiding this comment.
can fix this in a follow-on, but suggest:
Suggested change
| - TVM requires LLVM for CPU codegen. We highly recommend you to build with the LLVM support on. | |
| - TVM requires LLVM for CPU codegen. When building for compilation purposes, we highly recommend you to build with the LLVM support on. |
shingjan
pushed a commit
to shingjan/tvm
that referenced
this pull request
May 17, 2022
- Remove TVM's `USE_CCACHE` option in favor
of CMake's built-in `CMAKE_C_COMPILER_LAUNCHER`
and `CMAKE_CXX_COMPILER_LAUNCHER` variables.
This eliminates a significant source of
complexity, especially:
- TVM's CI scripts, which use `sccache`
instead of `ccache`, and
- calls to `ExternalProject_add` in TVM's CMake logic.
- Ensure that `CMAKE_C[XX]_COMPILER_LAUNCHER` variables
are passed through in all `ExternalProject_add` calls.
- Update user documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build] Fix
ccachelogic in build system.Fix several bugs in existing ccache logic.
When building for Hexagon, ensure that
related CMake variables propagate through
CMake
ExternalProject_addcalls.Add user documentation for enabling ccache
in TVM builds.