Skip to content

Conversation

@cconvey
Copy link
Contributor

@cconvey cconvey commented May 9, 2022

[build][hexagon] fix several compiler warnings

Fix several compiler warnings for Hexagon code.

cc @mehrdadh

@cconvey cconvey force-pushed the fix-hexagon-compiler-warnings branch from 6c67b2f to a0c58ac Compare May 9, 2022 14:46
@github-actions github-actions bot requested a review from mehrdadh May 9, 2022 14:46
@cconvey cconvey force-pushed the fix-hexagon-compiler-warnings branch from a0c58ac to e461dc8 Compare May 9, 2022 14:50
@cconvey cconvey changed the title [build][hexagon] disable warning in generated code [build][hexagon] fix several compiler warnings May 9, 2022
@cconvey cconvey marked this pull request as draft May 9, 2022 14:51
@cconvey cconvey force-pushed the fix-hexagon-compiler-warnings branch from e461dc8 to 9e013e4 Compare May 9, 2022 18:37
@cconvey cconvey marked this pull request as ready for review May 9, 2022 19:42
@cconvey
Copy link
Contributor Author

cconvey commented May 9, 2022

CC: @kparzysz-quic

Copy link
Contributor

@kparzysz-quic kparzysz-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of comments.

@cconvey cconvey changed the title [build][hexagon] fix several compiler warnings WIP [build][hexagon] fix several compiler warnings May 10, 2022
@cconvey
Copy link
Contributor Author

cconvey commented May 13, 2022

I'll slightly rework this PR once #11245 is merged.

@cconvey cconvey force-pushed the fix-hexagon-compiler-warnings branch from 9e013e4 to c63e08c Compare May 13, 2022 18:10
@cconvey cconvey changed the title WIP [build][hexagon] fix several compiler warnings [build][hexagon] fix several compiler warnings May 13, 2022
@cconvey cconvey force-pushed the fix-hexagon-compiler-warnings branch from c63e08c to e3ae8d7 Compare May 15, 2022 17:53
@cconvey
Copy link
Contributor Author

cconvey commented May 15, 2022

@mehrdadh : Ready for merge if/when you're happy.

Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mehrdadh mehrdadh merged commit ebf3607 into apache:main May 16, 2022
@cconvey cconvey deleted the fix-hexagon-compiler-warnings branch May 16, 2022 21:23
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
shingjan pushed a commit to shingjan/tvm that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants