[Runtime][PipelineExecutor] Add graph manually splitting logic into the unit test. #11334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huajsj
changed the title
15 tasks
Contributor
Author
|
@SebastianBoblestETAS , please take a look. |
Contributor
Author
|
@SebastianBoblestETAS, all review comments addressed, please take a look. |
SebastianBoblest
approved these changes
May 19, 2022
Contributor
SebastianBoblest
left a comment
SebastianBoblest
left a comment
There was a problem hiding this comment.
LGTM, two minor typos should be fixed.
Note that I can not really judge the functionality of this test, not my area of expertise.
the unit test. Current unit test create 3 seperate module then re-connect them to run the pipeline executor. And this is not a real use case for pipeline executor. Adding a manually graph splitting logic which split a full network into 3 subgraph then run the pipeline executor and verify the result to simulate the real use case.
Contributor
Author
|
@masahi , please take a look. |
masahi
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://github.com/apache/tvm-rfcs/blob/main/rfcs/0014-pipeline-executor.md
Issue: #8596
Current unit test create 3 seperate module then re-connect them to run the pipeline executor. And this is not a real use case for pipeline executor.
Adding a manually graph splitting logic which split a full network into 3 subgraph then run the pipeline executor and verify the result to simulate the real use case .