Skip to content

Thread safe initialization for JSONRuntime module #11339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
May 17, 2022
Merged

Thread safe initialization for JSONRuntime module #11339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/runtime/contrib/json/json_runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,11 @@ class JSONRuntimeBase : public ModuleNode {
// The function to initialize constant tensors.
return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) {
ICHECK_EQ(args.size(), 1U);
this->Init(args[0]);
this->initialized_ = true;
std::lock_guard<std::mutex> guard(this->initialize_mutex_);
if (!this->initialized_) {
this->Init(args[0]);
this->initialized_ = true;
}
*rv = 0;
});
} else {
Expand Down Expand Up @@ -270,6 +273,8 @@ class JSONRuntimeBase : public ModuleNode {
std::vector<uint32_t> const_idx_;
/*! \brief Indicate if the engine has been initialized. */
bool initialized_{false};
/*! \brief Initializer mutex*/
std::mutex initialize_mutex_;
};

} // namespace json
Expand Down