[Topi] [Hexagon] Conv2d slice op initial version #11489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-sanirudh
force-pushed
the
conv2d_slice
branch
from
913fca3 to
ff6322d
Compare
Member
|
cc @Lunderberg @cconvey for review. |
quic-sanirudh
force-pushed
the
conv2d_slice
branch
from
ff6322d to
13868a6
Compare
quic-sanirudh
force-pushed
the
conv2d_slice
branch
3 times, most recently
from
8886c6b to
ec94e08
Compare
Contributor
Author
|
@Lunderberg @cconvey Could you please take a look at this patch when you get a chance. I just rebased it to take advantage of Jyotsna's utils functions, so I think it's ready for review now. |
Lunderberg
reviewed
Jun 24, 2022
Contributor
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
Looks good to me, just one question on the layout argument types.
quic-sanirudh
force-pushed
the
conv2d_slice
branch
3 times, most recently
from
b9dc9cb to
bb2a8fa
Compare
Member
|
I restarted the job, not sure why CI wasn't started. |
quic-sanirudh
force-pushed
the
conv2d_slice
branch
from
bb2a8fa to
48a2172
Compare
Contributor
Author
Thanks for this @mehrdadh. I just saw that there was a conflict in a file, so I just rebased my branch on top of main. |
quic-sanirudh
force-pushed
the
conv2d_slice
branch
from
48a2172 to
8a9d306
Compare
Contributor
Author
|
@Lunderberg @mehrdadh Are there any more comments and if not, could you please help get this merged. |
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the initial python implementation conv2d slice op for hexagon.
Slice ops are basically ops that make certain assumptions about the input and output dimensions and are expected to be called after the original op has been sliced according to those dimensions at the graph level.
cc @mehrdadh