Skip to content

Conversation

@quic-sanirudh
Copy link
Contributor

@quic-sanirudh quic-sanirudh commented Jun 2, 2022

Update to LLVM 14.0.0 release for ci_hexagon docker image.

cc @Mousius @areusch @driazati

@cconvey
Copy link
Contributor

cconvey commented Jun 2, 2022

Not sure if this is off-topic, but is there a reason we're not using the LLVM version that comes with the Hexagon SDK / Hexagon Toolchain?

@areusch
Copy link
Contributor

areusch commented Jun 2, 2022

@quic-sanirudh i think the CI image build is busted right now due to tflite install. let me see if i can fix that

@quic-sanirudh
Copy link
Contributor Author

quic-sanirudh commented Jun 2, 2022

Not sure if this is off-topic, but is there a reason we're not using the LLVM version that comes with the Hexagon SDK / Hexagon Toolchain?

I'm not sure if this was discussed earlier. I guess using the LLVM version that comes with the Hexagon Toolchain might work, but one reason I personally would prefer using the upstream release is that the LLVM version that comes with the Toolchain would only be built to support Hexagon target and probably a separate LLVM build for ARM/X86 target.

This might be a problem if we ever wish to run tests/models for both llvm and hexagon target.

Maybe @kparzysz-quic might have a better answer to this question.

@quic-sanirudh
Copy link
Contributor Author

@areusch @cconvey Can you review and merge this PR when you get a chance. This would enable a bunch of PRs to be rebuilt and merged related to hexagon slice ops.

@jverma-quic
Copy link
Contributor

Not sure if this is off-topic, but is there a reason we're not using the LLVM version that comes with the Hexagon SDK / Hexagon Toolchain?

I'm not sure if this was discussed earlier. I guess using the LLVM version that comes with the Hexagon Toolchain might work, but one reason I personally would prefer using the upstream release is that the LLVM version that comes with the Toolchain would only be built to support Hexagon target and probably a separate LLVM build for ARM/X86 target.

This might be a problem if we ever wish to run tests/models for both llvm and hexagon target.

Maybe @kparzysz-quic might have a better answer to this question.

@cconvey - In addition to what @quic-sanirudh mentioned above, the Hexagon toolchain in SDK doesn't have fp16 support so it wouldn't work.

@mehrdadh
Copy link
Member

mehrdadh commented Jun 3, 2022

@quic-sanirudh thanks for the PR. LGTM!
I will merge this, note that the image used by CI will be not be automatically updated. You need to send another PR to update it. I can show you how.

@mehrdadh mehrdadh merged commit cee74c9 into apache:main Jun 3, 2022
@mehrdadh
Copy link
Member

mehrdadh commented Jun 3, 2022

@quic-sanirudh I ran a job to build all docker images and test them: https://ci.tlcpack.ai/job/docker-images-ci/job/daily-docker-image-rebuild/
Once that is finished green, you can open a PR and update the docker tag from this build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants